ephraimbuddy commented on code in PR #59430:
URL: https://github.com/apache/airflow/pull/59430#discussion_r2655072558
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2663,6 +2663,22 @@ dag_processor:
type: boolean
example: ~
default: "True"
+ dag_stability_check_level:
+ description: |
+ Controls the behavior of dag stability checker performed before DAG
parsing in the dag-processor.
+ Static checks detect potential issues such as runtime-varying values
in DAG/Task constructors
+ that could cause DAG version inflation.
+
+ * ``off``: Disables dag stability checks entirely. No errors or
warnings are generated.
+ * ``warning``: DAGs load normally but warnings are displayed in the UI
when issues are detected.
Review Comment:
```suggestion
* ``warning``: Dags load normally but warnings are displayed in the
UI when issues are detected.
```
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2663,6 +2663,22 @@ dag_processor:
type: boolean
example: ~
default: "True"
+ dag_stability_check_level:
+ description: |
+ Controls the behavior of dag stability checker performed before DAG
parsing in the dag-processor.
+ Static checks detect potential issues such as runtime-varying values
in DAG/Task constructors
+ that could cause DAG version inflation.
Review Comment:
```suggestion
Controls the behavior of dag stability checker performed before Dag
parsing in the dag-processor.
The check detects potential issues such as runtime-varying values in
Dag/Task constructors
that could cause Dag version inflation.
```
We might need to word the first line to reflect exactly that this is about
version inflation
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2663,6 +2663,22 @@ dag_processor:
type: boolean
example: ~
default: "True"
+ dag_stability_check_level:
Review Comment:
I think it will be more clear to call this:
`dag_version_inflation_check_level` for easy discovery and understanding but no
strong opinion here
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -229,8 +242,7 @@ def _parse_file(msg: DagFileParseRequest, log:
FilteringBoundLogger) -> DagFileP
fileloc=msg.file,
serialized_dags=serialized_dags,
import_errors=bag.import_errors,
- # TODO: Make `bag.dag_warnings` not return SQLA model objects
- warnings=[],
+
warnings=stability_check_result.get_warning_dag_format_dict(bag.dag_ids),
Review Comment:
Will this not override other dag warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
