[
https://issues.apache.org/jira/browse/AIRFLOW-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985880#comment-16985880
]
ASF GitHub Bot commented on AIRFLOW-6144:
-----------------------------------------
seii-saintway commented on pull request #6710: [AIRFLOW-6144] Improve the log
message of airflow scheduler
URL: https://github.com/apache/airflow/pull/6710
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
`[2019-12-02 14:33:56,384] {dag_processing.py:760} ERROR - Cannot use more
than 1 thread when using sqlite. Setting parallelism to 1`
↓
`[2019-12-02 14:33:56,384] {dag_processing.py:760} WARNING - Because we
cannot use more than 1 thread (max_threads = %d) when using sqlite. So we set
parallelism to 1.`
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Because there are no corresponding unit tests for the log message before, I
just did a quick test.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve the log message of airflow scheduler
> --------------------------------------------
>
> Key: AIRFLOW-6144
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6144
> Project: Apache Airflow
> Issue Type: Improvement
> Components: DagRun
> Affects Versions: 1.10.6
> Reporter: Andrew Sheng
> Priority: Minor
>
> It is a little difficult to understand the error message of airflow scheduler.
> {code:java}
> # start the scheduler
> airflow scheduler{code}
> {code:java}
> [2019-12-02 14:33:56,384] {dag_processing.py:760} ERROR - Cannot use more
> than 1 thread when using sqlite. Setting parallelism to 1{code}
> After I initialized the database as Quick Start description, the
> _max_threads_ was configured to 2 by default. Then I continued running the
> command _airflow scheduler_ as Quick Start description, but got an error
> message. It made me a little confusion.
> So I have no choice but to confirm the logic in the _dag_processing.py:760_.
> {code:java}
> self._parallelism = conf.getint('scheduler', 'max_threads')
> if 'sqlite' in conf.get('core', 'sql_alchemy_conn') and
> self._parallelism > 1:
> self.log.error("Cannot use more than 1 thread when using sqlite. "
> "Setting parallelism to 1")
> self._parallelism = 1{code}
> And I found that there were no problems which I have to deal with. It had
> been solved by itself.
> Instead of outputting ERROR message, I think it is better to output WARNING
> message as below.
> {code:java}
> [2019-12-02 14:33:56,384] {dag_processing.py:760} WARNING - Because we cannot
> use more than 1 thread (max_threads = %d) when using sqlite. So we set
> parallelism to 1.{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
