jason810496 commented on code in PR #59997: URL: https://github.com/apache/airflow/pull/59997#discussion_r2656139353
########## airflow-e2e-tests/tests/airflow_e2e_tests/basic_tests/test_dag_test_method.py: ########## @@ -0,0 +1,225 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""E2E tests for dag.test() method.""" + +from __future__ import annotations + +import json + +import pytest + +from airflow_e2e_tests.conftest import _E2ETestState + + +def _execute_dag_test(dag_id: str, use_executor: bool = False) -> dict: Review Comment: It would be nice to follow the existed e2e test convention as example. So instead of defining explicit ORM session query python code as str, we could take `airflow-e2e-tests/tests/airflow_e2e_tests/remote_log_tests/test_remote_logging.py` as example then use `AirflowClient` instead of the python code as string pattern here. ########## airflow-e2e-tests/tests/airflow_e2e_tests/dags/test_dag_test_branching.py: ########## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Test DAG with branching logic for testing dag.test() method.""" + +from __future__ import annotations + +from airflow.providers.standard.operators.bash import BashOperator +from airflow.providers.standard.operators.python import BranchPythonOperator +from airflow.sdk import DAG, task + + Review Comment: For these example dags, not sure would it be a good idea to just add symbolic link for existing example dag (e.g. `airflow-core/src/airflow/example_dags/example_xcom.py` ) cc @gopidesupavan WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
