ashb commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#discussion_r352545774
########## File path: airflow/jobs/scheduler_job.py ########## @@ -54,8 +54,9 @@ from airflow.utils.state import State -class DagFileProcessor(AbstractDagFileProcessor, LoggingMixin): - """Helps call SchedulerJob.process_file() in a separate process. +class DagFileProcessorRunner(AbstractDagFileProcessorRunner, LoggingMixin): Review comment: Do we really need a separate class for DagFileProcessorRunner and DagFileProcessor -- the "Runner" version doesn't seem like it adds much (they are always created together in the same process) so I think I'd prefer this as just a single class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
