ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags 
returned by task_stats
URL: https://github.com/apache/airflow/pull/6684#discussion_r352554650
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -403,7 +405,7 @@ <h2>DAGs</h2>
           container: "body",
         });
       });
-      d3.json("{{ url_for('Airflow.task_stats') }}", function(error, json) {
+      d3.json("{{ url_for('Airflow.task_stats') }}?dag_ids=" + 
all_dags_ids.join(','), function(error, json) {
 
 Review comment:
   is `,` allowed in DAGids? 😁 
   
   Also this parameter needs to be URI escaped, or bettwer yet if `d3.json` 
supports it `d3.json("{{ url_for('Airflow.task_stats') }}", {"dag_ids": 
all_dags_ids.join(',') }, function(error, json) {`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to