amoghrajesh opened a new pull request, #60044:
URL: https://github.com/apache/airflow/pull/60044
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Tests on main are broken similar to:
```python
________________________________________________________________
test_dag_state_change_process_pool_size_invalid_value_raise_error[false]
________________________________________________________________
task-sdk/src/airflow/sdk/_shared/configuration/parser.py:1050: in getint
return int(val)
E ValueError: invalid literal for int() with base 10: 'false'
During handling of the above exception, another exception occurred:
providers/openlineage/tests/unit/openlineage/test_conf.py:554: in
test_dag_state_change_process_pool_size_invalid_value_raise_error
dag_state_change_process_pool_size()
providers/openlineage/src/airflow/providers/openlineage/conf.py:155: in
dag_state_change_process_pool_size
return conf.getint(_CONFIG_SECTION,
"dag_state_change_process_pool_size", fallback="1")
task-sdk/src/airflow/sdk/_shared/configuration/parser.py:1052: in getint
raise AirflowConfigException(
E airflow.sdk._shared.configuration.exceptions.AirflowConfigException:
Failed to convert value to int. Please check
"dag_state_change_process_pool_size" key in "openlineage" section. Current
value: "false".
```
This is because of https://github.com/apache/airflow/pull/60026. This PR
moved `conf` to compat sdk but not `AirflowConfigException`, so there was a
mismatch in the exception raised and captured. Expected:
`airflow.exceptions.AirflowConfigException`, caught:
`airflow.sdk._shared.configuration.exceptions.AirflowConfigException`.
Hence, moving this exception into compat sdk as well. It would be beneficial
in long run to do this.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
