zach-overflow opened a new pull request, #60053:
URL: https://github.com/apache/airflow/pull/60053
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
Related to: https://github.com/apache/airflow/issues/59871
## What?
* Adds section on reproducing CI migration tests in a development
environment.
* Adds a warning about ORM references in migration scripts.
* Cleans up section / sub-section formatting for clearer topic segmentation.
## Why?
* There are a number of recent threads in the Airflow Slack (including
several I started) with questions on reproducing migration test failures in CI.
* As detailed more thoroughly in the related issue (linked above) ORM
references in alembic migration scripts can cause problems for future
migrations and downgrade-ability. Even after we have a pre-commit check to
prevent this, we should still explain why that practice is discouraged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]