ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352566346
########## File path: airflow/models/dagbag.py ########## @@ -406,8 +404,10 @@ def collect_dags( FileLoadStat = namedtuple( 'FileLoadStat', "file duration dag_num task_num dags") + from airflow.utils.file import correct_maybe_zipped dag_folder = correct_maybe_zipped(dag_folder) + from airflow.utils.file import list_py_file_paths Review comment: Small nit: we could combine the two imports in to a single line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services