ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid
unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r352582982
##########
File path: airflow/jobs/local_task_job.py
##########
@@ -112,13 +111,6 @@ def signal_handler(signum, frame):
"exceeded limit ({}s)."
.format(time_since_last_heartbeat,
heartbeat_time_limit))
-
- if time_since_last_heartbeat < self.heartrate:
Review comment:
Ah - the the check above is done _after_ calling `self.heartbeat()` which
means it may have just updated the `latest_heartbeat` -- should that check be
done before calling `heartbeat()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
