jason810496 commented on code in PR #58852:
URL: https://github.com/apache/airflow/pull/58852#discussion_r2660138201
##########
airflow-core/src/airflow/models/dag.py:
##########
@@ -365,6 +365,8 @@ class DagModel(Base):
timetable_summary: Mapped[str | None] = mapped_column(Text, nullable=True)
# Timetable description
timetable_description: Mapped[str | None] = mapped_column(String(1000),
nullable=True)
+ # Timetable Type
+ timetable_type: Mapped[str | None] = mapped_column(String(255),
nullable=True)
Review Comment:
It seems we could set the type as `str` instead of `str | None`, as we can
ensure `dm.timetable_type` will not be none while dag_processing. Additionally,
the `type_name` property will never be `None`.
https://github.com/apache/airflow/pull/58852/changes#diff-8640613973be948ed8c50ee1eb85cb1f8f3f18df7c17b54057b550142bc4f133R540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
