shivannakarthik commented on code in PR #60083: URL: https://github.com/apache/airflow/pull/60083#discussion_r2660283395
########## providers/google/src/airflow/providers/google/cloud/operators/dataproc.py: ########## @@ -25,7 +25,7 @@ import warnings from collections.abc import MutableSequence, Sequence from dataclasses import dataclass -from datetime import datetime, timedelta +from datetime import datetime, timedelta, timezone Review Comment: ``` - from airflow.utils import timezone + from datetime import datetime, timedelta, timezone - utc_auto_delete_time = timezone.convert_to_utc(self.auto_delete_time) + utc_auto_delete_time = self.auto_delete_time.astimezone(timezone.utc) ``` Could you please clarify if these changes are related to this bug fix? I'd suggest either removing this change entirely as I believe it's unrelated to the PR scope or create a separate PR with proper testing for naive datetime handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
