amoghrajesh opened a new pull request, #60114:
URL: https://github.com/apache/airflow/pull/60114
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This is a precursor to: https://github.com/apache/airflow/pull/59956 to
remove usages of `airflow` references in shared libraries.
There are some utilities like this one: `find_path_from_directory` which is
needed in dag path discovery as well in plugins manager. Right now its present
in `utils.file`.
Since it is a module_loading related utility, moving it to module_loading
shared library made the most sense. This allows shared libraries like
plugins_manager to use the
function without importing from `airflow.*`
Changes of note:
- New file `shared/module_loading/file_discovery.py`
- Update `airflow.utils.file` to import from shared and inline config
- Update `plugins_manager` to import from shared library
The method in shared library defaults to "glob" syntax. Any callers that
needed a change have been updated to instead inject the dependency config after
reading it from `conf`
Deprecation works:
```python
from airflow.utils.file import find_path_from_directory
<ipython-input-2-a3047d0a2d8f>:1 DeprecatedImportWarning: Importing
find_path_from_directory from airflow.utils.file is deprecated and will be
removed in a future version. Use
airflow._shared.module_loading.find_path_from_directory instead.
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
