jscheffl commented on code in PR #59922:
URL: https://github.com/apache/airflow/pull/59922#discussion_r2660477861


##########
airflow-core/newsfragments/59835.significant.rst:
##########
@@ -1,5 +1,6 @@
 Methods removed from TaskInstance
 
-On class ``TaskInstance``, functions ``run()``, ``render_templates()``, and
-private members related to them have been removed. The class has been
-considered internal since 3.0, and should not be relied on in user code.
+On class ``TaskInstance``, functions ``run()``, ``render_templates()``,
+``get_template_context()``, and private members related to them have been
+removed. The class has been considered internal since 3.0, and should not be
+relied on in user code.

Review Comment:
   I barely remember and might need to research on our codebase at work, I 
think we used it in the Cluster Colicies in the Scheduler where there was no 
direct execution context of a task execution. But I might be wrong (as not 
being on my work PC atm)
   
   But yeah during a task execution I do understand, then you need to pass the 
context in the call-chain down to your logic. That makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to