[ 
https://issues.apache.org/jira/browse/AIRFLOW-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986140#comment-16986140
 ] 

Ash Berlin-Taylor commented on AIRFLOW-3407:
--------------------------------------------

It's probably okay/right for BaseOperator not to pass on extra args, but 
LoggingMixin probably should - as it is intended to be mixed in to other 
classes :)

> BaseOperator and LoggingMixin do not call super().__init__
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-3407
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3407
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.1
>            Reporter: adam hitchcock
>            Assignee: Chao-Han Tsai
>            Priority: Major
>
> TheĀ {{BaseOperator}} is not necessarily the last class in the MRO; usually it 
> is best practice to always call {{super().__init__(*args, **kwargs)}}
>  to make sure that every class gets it chance to {{__init__}}.
> Is there a specific reason {{BaseOperator}} doesn't call super?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to