Arunodoy18 commented on code in PR #60012:
URL: https://github.com/apache/airflow/pull/60012#discussion_r2661372121
##########
airflow-core/src/airflow/migrations/versions/0015_2_9_0_update_trigger_kwargs_type.py:
##########
@@ -78,14 +65,8 @@ def downgrade():
------------
""")
)
- else:
- session = get_session()
- try:
- for trigger in
session.query(Trigger).options(lazyload(Trigger.task_instance)):
- trigger.encrypted_kwargs =
json.dumps(BaseSerialization.serialize(trigger.kwargs))
- session.commit()
- finally:
- session.close()
+ # Note: The original migration used ORM to attempt serialization, but this
is not necessary
+ # for the downgrade. The column type change below handles the conversion.
Review Comment:
Yeah it was done , I did test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
