aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip 
serve_logs process with workers
URL: https://github.com/apache/airflow/pull/6709#discussion_r352718565
 
 

 ##########
 File path: airflow/cli/commands/worker_command.py
 ##########
 @@ -59,6 +62,12 @@ def worker(args):
     if conf.has_option("celery", "pool"):
         options["pool"] = conf.get("celery", "pool")
 
+    if skip_serve_logs is False:
+        print(
+            "Starting serve logs process within worker is going to be 
deprecated, "
 
 Review comment:
   Are we sure we want to deprecate this in 2.0? One of the current principles 
of Airflow is to make it work out of the box so this log serving may still be a 
good default to have.
   
   If we want to keep the warning should probably use log. syntax instead of 
print()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to