potiuk commented on PR #60133: URL: https://github.com/apache/airflow/pull/60133#issuecomment-3712287971
BTW. You might freely continue rebasing your PR and base your testing on top of it - while the discussion is happening. There is no need to merge it to do it, what is more important though is that we decide - as a community whether we are going to support it - even for testing purposes. Context: We had very bad experience with MsSQL in the past and we eventually had to remove it (we were lucky it was merged as "experimental" - but a lot of our users who used it had problems when we removed it and wanted it to continue - even if it was clearly marked as "experimental". Now I understand what you are saying that it's "close enough to MySQL", but this is a completely vague statement that does not even attempt to describe "how close" it is. In the past for example there was a LONG period of time SKIP LOCKED was not supported by MariaDB. And we are currently using **some** features from MySQL like json fields etc. that might prove to behave differently, even the PR https://github.com/apache/airflow/pull/60047 shows that there are some significant changes that will make it more difficult to maintain and keep mariadb support in parallel to mysql. This PR is a proof that there are differences - and ones that add maintenance overhead. So my best guess (but again - you MUST start devlist discussion if you want to support it) you will have to show exactly what kind of changes are necessary to support MariaDB in order to even begin a discussion "should we merge it". Which basically means that you will have to heave the PR green, when running it with your changes and have all the tests passing. And you - rebasing it continuously - will be able to see also - while other changes is implemented, how much extra maintenance it is to keep your PR is green - this is a great opportunity to either proof that it is fine - if it will be relatively painless to keep it green over the course of weeks or months, or whether it is actually difficult and will require maintainers to spend extra time to test and fix issues. So there are only good things with keeping your PR open and continuously rebased - while the discussion is running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
