vatsrahul1001 commented on PR #59744:
URL: https://github.com/apache/airflow/pull/59744#issuecomment-3714458495
> > @Coding-Alchemist-Abhijay did you get a chance to fix the review comment?
>
> Hi @vatsrahul1001 , sorry for the delay in addressing this.
>
> I tried my best to cleanly address and fix all the review comments you
mentioned (removing explicit login due to auth sharing, avoiding non-existent
selectors, following the page object pattern, and adding a proper assertion for
DAG code visibility.
>
> I spent some time trying to run the UI E2E tests locally so I could
properly validate and debug the failure around getByRole("tab", { name: "Code"
}). Unfortunately, I ran into multiple issues setting up Airflow locally on my
Windows environment. At different points, my WSL/bash environment broke, and I
also faced Breeze-related issues (Docker/Breeze commands failing or not being
recognized), which prevented me from getting a stable local setup to iterate on
the test.
>
> From reviewing the behavior and the UI implementation, the failure does
not seem to be with the Code tab itself, but rather with the selector.
getByRole("tab", { name: "Code" }) relies on ARIA roles and accessible names,
which may not be immediately available or consistent during initial
render/hydration. Because of that, the selector can fail even when the Code tab
is visibly present and functional in the UI.
>
> Being able to run Airflow locally would have allowed me to confirm the
exact timing/ARIA behavior and adjust the selector accordingly, but I wasn’t
able to get a working local setup despite several attempts. I’m still learning
the Airflow + Breeze workflow on Windows, and I apologize for the delay this
caused.
>
> If you have suggestions on how best to handle or stabilize the
getByRole("tab", { name: "Code" }) selector in this context, I’d really
appreciate the guidance and will be happy to update the test accordingly.
>
> Thanks for your patience and for the review.
@Coding-Alchemist-Abhijay Thanks for fixes. I have added review comments
That should help with you concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
