KyeongJooni commented on code in PR #59738: URL: https://github.com/apache/airflow/pull/59738#discussion_r2664934261
########## airflow-core/src/airflow/ui/tests/e2e/specs/backfill-controls.spec.ts: ########## @@ -0,0 +1,121 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, test } from "@playwright/test"; +import { testConfig, AUTH_FILE } from "playwright.config"; +import { BackfillPage } from "tests/e2e/pages/BackfillPage"; + +const getPastDate = (daysAgo: number): string => { + const date = new Date(); + + date.setDate(date.getDate() - daysAgo); + date.setHours(0, 0, 0, 0); + + return date.toISOString().slice(0, 16); +}; + +test.describe("Backfill Controls", () => { + const testDagId = testConfig.testDag.id; + const fromDate = getPastDate(2); Review Comment: @vatsrahul1001 Updated per your feedback: - Moved tests to backfill.spec.ts (removed backfill-controls.spec.ts) - Implemented beforeEach/afterEach pattern with serial mode - Replaced waitForTimeout with explicit state waits - Removed unused methods (isBackfillDateErrorVisible, waitForBackfillCompletion) - Removed duplicate test Regarding the partial selector `aria-label*="ancel"`: kept it to support potential localized button labels, but happy to make it more specific if needed. Thank you for the detailed review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
