vatsrahul1001 commented on PR #59939:
URL: https://github.com/apache/airflow/pull/59939#issuecomment-3714790733
@junaiddshaukat Thanks for the PR! A few things to address:
1. Coordinate with PR #59990 - Both PRs create different files for assets.
Work together to use single `AssetsPage.ts`
2. Add `beforeAll` for data setup - Tests assume asset exists with producing
tasks. Add setup to trigger `asset_produces_1` DAG and unpause consumer
3. Fix fragile selectors:
- `label.locator("..")` relies on DOM structure
- `.chakra-popover__body` is framework-specific
5. Test naming - Use "verify" prefix without "should"
6. Remove unused code - `assetsTable` locator is never used
7. Refactor duplicate code - `verifyProducingTasks` and
`verifyScheduledDags` are nearly identical
Let me know if you have questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
