sarth-akvaish commented on PR #59990:
URL: https://github.com/apache/airflow/pull/59990#issuecomment-3715129652
> @sarth-akvaish Thanks for the PR! A few things to address:
>
> 1. Add `beforeAll` to trigger producer DAG - Tests assume assets exist.
Add setup that unpause consumer DAG and triggers `asset_produces_1` to create
real asset data:
> test.beforeAll(async ({ browser }) => {
> // Trigger asset_produces_1 to create asset data
> });
>
> Also maybe trigger multiple dags which uses assets and it will help in
search test to filter 2. Coordinate with PR #59939 - Both PRs create different
page objects. Work together to use single `AssetsPage.ts` and `assets.spec.ts`
>
> 3. Test naming - Use "verify" prefix
> 4. Fix fragile selectors - Be more specific
> 5. Pagination - Use `?offset=0&limit=1` URL param
>
> Let me know if you have questions
Hi @vatsrahul1001, Thanks for the review. I’ll incorporate the suggested
changes and update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
