Saadmadni84 commented on code in PR #60105: URL: https://github.com/apache/airflow/pull/60105#discussion_r2666115117
########## airflow-core/src/airflow/ui/src/pages/DagsList/TaskInstanceSummary.tsx: ########## @@ -0,0 +1,82 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { HStack, Spinner, Text } from "@chakra-ui/react"; +import { useTranslation } from "react-i18next"; + +import { useTaskInstanceServiceGetTaskInstances } from "openapi/queries"; +import type { TaskInstanceState } from "openapi/requests/types.gen"; +import { StateBadge } from "src/components/StateBadge"; +import { Stat } from "src/components/Stat"; + +type Props = { + readonly dagId: string; + readonly runId: string; +}; + +export const TaskInstanceSummary = ({ dagId, runId }: Props) => { + const { t: translate } = useTranslation("common"); + + const { data, isLoading } = useTaskInstanceServiceGetTaskInstances({ + dagId, + dagRunId: runId, + limit: 1000, + }); Review Comment: I manually tested the DAGs list page with ~100 DAGs visible, including DAGs with latest runs and a large DAG containing ~1000 tasks. Each DAG card issues a getTaskInstances request with limit=1000, resulting in many parallel XHR requests. The page remains functional but network activity is heavy and page load settles slowly, which validates the concern about scaling. I agree this would benefit from batching or a summarized endpoint and suggest addressing that in a follow-up PR to keep this change focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
