bbovenzi commented on code in PR #59507:
URL: https://github.com/apache/airflow/pull/59507#discussion_r2666403035
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/BlockingDeps.tsx:
##########
@@ -22,14 +22,25 @@ import { useTranslation } from "react-i18next";
import { useTaskInstanceServiceGetTaskInstanceDependencies } from
"openapi/queries";
import type { TaskInstanceResponse } from "openapi/requests/types.gen";
-export const BlockingDeps = ({ taskInstance }: { readonly taskInstance:
TaskInstanceResponse }) => {
+type BlockingDepsProps = {
+ readonly refetchInterval: number | false;
Review Comment:
Let's not pass refetchInterval as a prop You can just do `const
refetchInterval = useAutoRefresh({ dagId });`
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx:
##########
@@ -22,16 +22,26 @@ import { useParams } from "react-router-dom";
import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries";
-export const ExtraLinks = () => {
+type ExtraLinksProps = {
+ readonly refetchInterval: number | false;
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
