pierrejeambrun commented on code in PR #59533:
URL: https://github.com/apache/airflow/pull/59533#discussion_r2667593525
##########
airflow-core/src/airflow/ui/src/components/DataTable/FilterMenuButton.tsx:
##########
@@ -29,6 +29,8 @@ type Props<TData> = {
};
const FilterMenuButton = <TData,>({ table }: Props<TData>) => {
+ "use no memo"; // remove if https://github.com/TanStack/table/issues/5567 is
resolved
+
const { t: translate } = useTranslation("common");
Review Comment:
We need to know when react compiler cannot optimize a component and fallback
to default behavior => the developer need to write explicit useMemo/useCallback
such as here.
I've read about `hooks/todo` eslint rule and silent react compiler failure,
I think we need that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
