kaxil commented on a change in pull request #6702: [AIRFLOW-6140] Add missing
types for some core classes. Depends on [AIRFLOW-6004]
URL: https://github.com/apache/airflow/pull/6702#discussion_r352921900
##########
File path: airflow/executors/executor_loader.py
##########
@@ -25,11 +25,11 @@ class ExecutorLoader:
Keeps constants for all the currently available executors.
"""
- LOCAL_EXECUTOR = "LocalExecutor"
- SEQUENTIAL_EXECUTOR = "SequentialExecutor"
- CELERY_EXECUTOR = "CeleryExecutor"
- DASK_EXECUTOR = "DaskExecutor"
- KUBERNETES_EXECUTOR = "KubernetesExecutor"
+ LOCAL_EXECUTOR: str = "LocalExecutor"
+ SEQUENTIAL_EXECUTOR: str = "SequentialExecutor"
+ CELERY_EXECUTOR: str = "CeleryExecutor"
+ DASK_EXECUTOR: str = "DaskExecutor"
+ KUBERNETES_EXECUTOR: str = "KubernetesExecutor"
Review comment:
Do we need to add `str` here? this are static variables that would always
contain string ??
May be yes, may be no.
Just laying out my thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
