[
https://issues.apache.org/jira/browse/AIRFLOW-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986485#comment-16986485
]
ASF GitHub Bot commented on AIRFLOW-6160:
-----------------------------------------
mik-laj commented on pull request #6717: [AIRFLOW-6160] Move
_check_and_change_state_before_execution to LocalTaskJob
URL: https://github.com/apache/airflow/pull/6717
Hello
I think that LocaclTaskJob should control which tasks are to be executed.
SchedulerJob and BackfillingJob behave similarly. Otherwise, we have
inconsistencies in the way these methods are placed, and the execution rules
from Scheduler and Backfilling should be moved to TaskInstance. However, I
think it's better when Jobs implements specific logic.
Best regards
---
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6160
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move _check_and_change_state_before_execution to LocalTaskJob
> -------------------------------------------------------------
>
> Key: AIRFLOW-6160
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6160
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 1.10.6
> Reporter: Kamil Bregula
> Priority: Major
>
> Hello
> I think that LocaclTaskJob should control which tasks are to be executed.
> SchedulerJob and BackfillingJob behave similarly.
> Best regards
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
