potiuk commented on PR #59413: URL: https://github.com/apache/airflow/pull/59413#issuecomment-3720598199
> I understand that the option itself is clear of the intent, but for users who enable it, it may not be clear that the Airflow worker can leave pods unsupervised in a Pending or Running state, and appear succesfull pods after their execution. That's why your idea of explaining what it does is good. Do it. The best way for **optional** choice where there is another choice that is **well named** and all of that is consistent, and - as you proposed - described including the context and consequences using it, this is fine. There might be good reasons why somoene wants to only remove success pods. maybe they already have automated cleanup of pods that are running or pending too long for example and they will be cleaned regardless for example. We cannot make all decisions for our users, but we can let them decide based on what we told them. This would be totally dfferent story if it was default behaviour. But it is not. You have to deliberately make your choice of the way you deal with Pods - and it's very clearly telling what it does. I don't think there is a need to deprecate this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
