bbovenzi commented on code in PR #60241:
URL: https://github.com/apache/airflow/pull/60241#discussion_r2670150824
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/Bar.tsx:
##########
@@ -29,27 +31,41 @@ import type { GridTask } from "./utils";
const BAR_HEIGHT = 100;
-type Props = {
+type BarHeaderProps = {
readonly max: number;
+ readonly onColumnClick?: () => void;
+ readonly run: GridRunsResponse;
+};
+
+type BarColumnProps = {
readonly nodes: Array<GridTask>;
readonly onCellClick?: () => void;
+ readonly run: GridRunsResponse;
+ readonly virtualItems?: Array<VirtualItem>;
+};
+
+type Props = {
+ readonly max: number;
+ readonly nodes?: Array<GridTask>;
+ readonly onCellClick?: () => void;
readonly onColumnClick?: () => void;
readonly run: GridRunsResponse;
+ readonly showHeader?: boolean;
+ readonly virtualItems?: Array<VirtualItem>;
};
-export const Bar = ({ max, nodes, onCellClick, onColumnClick, run }: Props) =>
{
+// Header-only component for the duration bar
+const BarHeader = ({ max, onColumnClick, run }: BarHeaderProps) => {
const { dagId = "", runId } = useParams();
const [searchParams] = useSearchParams();
const isSelected = runId === run.run_id;
-
const search = searchParams.toString();
- const { data: gridTISummaries } = useGridTiSummaries({ dagId, runId:
run.run_id, state: run.state });
return (
<Box
- _hover={{ bg: "brand.subtle" }}
- bg={isSelected ? "brand.muted" : undefined}
+ _hover={{ bg: "brand.muted" }}
+ bg={isSelected ? "brand.emphasized" : undefined}
Review Comment:
Colors were using `info` and `brand` inconsistently so I fixed that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
