ephraimbuddy commented on code in PR #59372:
URL: https://github.com/apache/airflow/pull/59372#discussion_r2672424714
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -487,12 +487,15 @@ def consume_logs(*, since_time: DateTime | None = None)
-> tuple[DateTime | None
message_timestamp = line_timestamp
progress_callback_lines.append(line)
else: # previous log line is complete
- for line in progress_callback_lines:
Review Comment:
> Thanks @ephraimbuddy, but I'd prefer to get a review of the open PR. I
specifically have a use for the modification to the callback args, and I think
its justified to modify them as prior to this looking from when the callbacks
were first added, the implementation has never worked, so it should be non
breaking.
Usually, if you have a different issue other than the lines repeating, it's
better to open a separate PR for that issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
