bbovenzi commented on code in PR #60237:
URL: https://github.com/apache/airflow/pull/60237#discussion_r2673828591
##########
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionForm.tsx:
##########
@@ -74,23 +76,21 @@ const ConnectionForm = ({
const paramsDic = { paramsDict:
connectionTypeMeta[selectedConnType]?.extra_fields ?? ({} as ParamsSpec) };
const [formErrors, setFormErrors] = useState(false);
+ const multiTeamEnabled = Boolean(useConfig("multi_team"));
useEffect(() => {
- reset((prevValues) => ({
- ...initialConnection,
- conn_type: selectedConnType,
- connection_id: prevValues.connection_id,
- }));
+ setValue("conn_type", selectedConnType, {
+ shouldDirty: true,
+ });
setConf(JSON.stringify(JSON.parse(initialConnection.extra), undefined, 2));
- }, [selectedConnType, reset, initialConnection, setConf]);
+ }, [selectedConnType, initialConnection, setConf, setValue]);
// Automatically reset form when conf is fetched
useEffect(() => {
- reset((prevValues) => ({
- ...prevValues, // Retain existing form values
- extra,
- }));
- }, [extra, reset, setConf]);
+ setValue("extra", extra, {
+ shouldDirty: true,
+ });
+ }, [extra, setValue]);
Review Comment:
What was he reason for this change?
##########
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionForm.tsx:
##########
@@ -74,23 +76,21 @@ const ConnectionForm = ({
const paramsDic = { paramsDict:
connectionTypeMeta[selectedConnType]?.extra_fields ?? ({} as ParamsSpec) };
const [formErrors, setFormErrors] = useState(false);
+ const multiTeamEnabled = Boolean(useConfig("multi_team"));
useEffect(() => {
- reset((prevValues) => ({
- ...initialConnection,
- conn_type: selectedConnType,
- connection_id: prevValues.connection_id,
- }));
+ setValue("conn_type", selectedConnType, {
+ shouldDirty: true,
+ });
setConf(JSON.stringify(JSON.parse(initialConnection.extra), undefined, 2));
- }, [selectedConnType, reset, initialConnection, setConf]);
+ }, [selectedConnType, initialConnection, setConf, setValue]);
// Automatically reset form when conf is fetched
useEffect(() => {
- reset((prevValues) => ({
- ...prevValues, // Retain existing form values
- extra,
- }));
- }, [extra, reset, setConf]);
+ setValue("extra", extra, {
+ shouldDirty: true,
+ });
+ }, [extra, setValue]);
Review Comment:
What was the reason for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
