jscheffl commented on code in PR #60254:
URL: https://github.com/apache/airflow/pull/60254#discussion_r2673941337
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -1069,6 +1080,7 @@ async def get_job_status(self, name: str, namespace: str)
-> V1Job:
job: V1Job = await v1_api.read_namespaced_job_status(
name=name,
namespace=namespace,
+ **with_timeout(),
Review Comment:
I think adding missing timeout is reasonable - but can you maybe find a way
that is on one global place and not scattert across many places where calls are
being made? Otherwise I fear this looks very complex and future extensions have
the risk missing one or the other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
