[ 
https://issues.apache.org/jira/browse/AIRFLOW-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986796#comment-16986796
 ] 

ASF GitHub Bot commented on AIRFLOW-4292:
-----------------------------------------

stale[bot] commented on pull request #5517: [AIRFLOW-4292] Cleanup and improve 
SLA code
URL: https://github.com/apache/airflow/pull/5517
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cleanup and improve SLA code
> ----------------------------
>
>                 Key: AIRFLOW-4292
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4292
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DAG, scheduler
>            Reporter: Sergio Kef
>            Assignee: Sergio Kef
>            Priority: Major
>
> There are currently a couple of issues open regarding SLAs.
> eg:
>  * AIRFLOW-249
>  * AIRFLOW-1216
>  * AIRFLOW-2892
> Admittedly, this function (`jobs.SchedulerJob.manage_slas`) could use some 
> improvements.
> I open this issue, to start cleaning up and improving code quality (without 
> affecting functionalities - for now).
> The exact problems I have identified:
>  * Improper data structures (eg lists that can either be replaced by 
> generators or sets)
>  * Smelly code (eg getting multiple times the current timestamp, redundant 
> filters)
>  * Code style, typos, 2-3 letter variable names, lack of comments
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to