sjyangkevin commented on code in PR #59653:
URL: https://github.com/apache/airflow/pull/59653#discussion_r2674417720
##########
providers/standard/tests/unit/standard/operators/test_hitl.py:
##########
@@ -138,19 +153,7 @@ def test_validate_options_with_empty_options(self) -> None:
@pytest.mark.parametrize(
("params", "exc", "error_msg"),
- (
- (ParamsDict({"_options": 1}), ValueError, '"_options" is not
allowed in params'),
- (
Review Comment:
Thanks for proposing the change. Wonder if this test case is removed. I
think it is checking for the situation "when a default value is provided for
the param, the default value should be valid for the type".
the proposed change seems to make the default value optional, but we should
probably keep this test case for the situation that default is provided.
##########
providers/standard/tests/unit/standard/operators/test_hitl.py:
##########
@@ -138,19 +153,7 @@ def test_validate_options_with_empty_options(self) -> None:
@pytest.mark.parametrize(
("params", "exc", "error_msg"),
- (
- (ParamsDict({"_options": 1}), ValueError, '"_options" is not
allowed in params'),
- (
- ParamsDict({"param": Param("", type="integer")}),
- ParamValidationError,
- (
- "Invalid input for param param: '' is not of type
'integer'\n\n"
- "Failed validating 'type' in schema:\n"
- " {'type': 'integer'}\n\n"
- "On instance:\n ''"
- ),
- ),
- ),
Review Comment:
Thanks for proposing the change. Wonder if this test case is removed. I
think it is checking for the situation "when a default value is provided for
the param, the default value should be valid for the type".
the proposed change seems to make the default value optional, but we should
probably keep this test case for the situation that default is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
