amoghrajesh commented on code in PR #60158: URL: https://github.com/apache/airflow/pull/60158#discussion_r2674966146
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,44 +1,37 @@ <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> +Thank you for contributing! -<!-- -Thank you for contributing! Please make sure that your code changes -are covered with tests. And in case of new features or big changes -remember to adjust the documentation. +Please provide above a brief description of the changes made in this pull request. +Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ + +Please make sure that your code changes are covered with tests. +And in case of new features or big changes remember to adjust the documentation. -Feel free to ping committers for the review! +Feel free to ping (in general) for the review if you do not see reaction for a few days +(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: -closes: #ISSUE -related: #ISSUE +* closes: #ISSUE +* related: #ISSUE +--> + +## Was generative AI tooling used to co-author this PR? Review Comment: Thanks for clarification, that was quite a read but makes sense ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,44 +1,37 @@ <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> +Thank you for contributing! -<!-- -Thank you for contributing! Please make sure that your code changes -are covered with tests. And in case of new features or big changes -remember to adjust the documentation. +Please provide above a brief description of the changes made in this pull request. +Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ + +Please make sure that your code changes are covered with tests. +And in case of new features or big changes remember to adjust the documentation. -Feel free to ping committers for the review! +Feel free to ping (in general) for the review if you do not see reaction for a few days +(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: -closes: #ISSUE -related: #ISSUE +* closes: #ISSUE +* related: #ISSUE +--> + +## Was generative AI tooling used to co-author this PR? Review Comment: Thanks for clarification, that was quite a read but makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
