vatsrahul1001 commented on code in PR #59943: URL: https://github.com/apache/airflow/pull/59943#discussion_r2675353059
########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,119 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; + +test.describe("Dag Tasks Tab", () => { + const testDagId = testConfig.testDag.id; + + test.beforeAll(async ({ browser }) => { + test.setTimeout(5 * 60 * 1000); + + const context = await browser.newContext({ storageState: AUTH_FILE }); + const page = await context.newPage(); + const dagPage = new DagsPage(page); + await dagPage.triggerDag(testDagId); + await dagPage.verifyDagRunStatus(testDagId, "success"); Review Comment: The method signature is verifyDagRunStatus(dagId, dagRunId), not (dagId, status). ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,119 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; Review Comment: Add imports import { testConfig, AUTH_FILE } from "playwright.config"; ########## airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts: ########## @@ -100,6 +143,10 @@ export class DagsPage extends BasePage { await this.navigateTo(DagsPage.getDagDetailUrl(dagName)); } + public async navigateToDagTasks(dagId: string = "example_bash_operator") { Review Comment: I see this is marked resolved but iys not ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,119 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; + +test.describe("Dag Tasks Tab", () => { + const testDagId = testConfig.testDag.id; + + test.beforeAll(async ({ browser }) => { + test.setTimeout(5 * 60 * 1000); + + const context = await browser.newContext({ storageState: AUTH_FILE }); + const page = await context.newPage(); + const dagPage = new DagsPage(page); + await dagPage.triggerDag(testDagId); + await dagPage.verifyDagRunStatus(testDagId, "success"); + + await context.close(); + }); + test("should navigate to tasks tab and show list", async ({ page }) => { + const dagPage = new DagsPage(page); + + await dagPage.navigateToDagTasks(DAG_ID); + + await expect(dagPage.tasksTab).toHaveAttribute("class", "active"); + await expect(dagPage.taskCards.first()).toBeVisible(); + }); + + test("should search tasks by name", async ({ page }) => { + const dagPage = new DagsPage(page); + + await dagPage.navigateToDagTasks(DAG_ID); Review Comment: ```suggestion await dagPage.navigateToDagTasks(testDagId); ``` ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,106 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; + +test.describe("Dag Tasks Tab", () => { + test("should navigate to tasks tab and show list", async ({ page }) => { Review Comment: This is still not resolved ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,106 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; Review Comment: we should remove this DAG_ID constant ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,106 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; + +test.describe("Dag Tasks Tab", () => { + test("should navigate to tasks tab and show list", async ({ page }) => { + const dagPage = new DagsPage(page); + + await dagPage.navigateToDagTasks(DAG_ID); + + await expect(dagPage.tasksTab).toHaveAttribute("class", "active"); Review Comment: Looks like not resolved ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-tasks.spec.ts: ########## @@ -0,0 +1,119 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test, expect } from "@playwright/test"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; + +const DAG_ID = "example_bash_operator"; + +test.describe("Dag Tasks Tab", () => { + const testDagId = testConfig.testDag.id; + + test.beforeAll(async ({ browser }) => { + test.setTimeout(5 * 60 * 1000); + + const context = await browser.newContext({ storageState: AUTH_FILE }); + const page = await context.newPage(); + const dagPage = new DagsPage(page); + await dagPage.triggerDag(testDagId); + await dagPage.verifyDagRunStatus(testDagId, "success"); + + await context.close(); + }); + test("should navigate to tasks tab and show list", async ({ page }) => { + const dagPage = new DagsPage(page); + + await dagPage.navigateToDagTasks(DAG_ID); Review Comment: should use testDagId -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
