potiuk commented on a change in pull request #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#discussion_r353139237
########## File path: airflow/serialization/serialized_dag.py ########## @@ -101,7 +102,7 @@ def deserialize_dag(cls, encoded_dag: dict) -> "SerializedDAG": setattr(dag, 'full_filepath', dag.fileloc) for task in dag.task_dict.values(): task.dag = dag - serializable_task: SerializedBaseOperator = task + serializable_task: SerializedBaseOperator = cast(SerializedBaseOperator, task) Review comment: I think it's worth looking at it @kaxil -> there are still some parts of the code that needs some more typing to catch potential errors (DagBag especially) but this one looks a bit fishy to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services