jason810496 commented on code in PR #60320:
URL: https://github.com/apache/airflow/pull/60320#discussion_r2675901389


##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -970,7 +971,7 @@ def _build_skaffold_config(
                 # include test sources (the `breeze k8s configure-cluster` 
command ) like nodeport for apiServer, volume for Dag, etc
                 # 
https://skaffold.dev/docs/references/yaml/?version=v4beta13#deploy-kubectl
                 "hooks": {
-                    "before": [
+                    "after": [

Review Comment:
   The hooks for deploying test resource (`nodeport.yaml`, `volume.yaml` in 
`scripts/ci/kubernetes` should be placed under `after` rather than `beforce`. 
Since the `airflow` namespace might not be exist before running `helm install`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to