pierrejeambrun commented on code in PR #60161:
URL: https://github.com/apache/airflow/pull/60161#discussion_r2676677130
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -921,11 +921,17 @@ def bulk_task_instances(
dag_bag: DagBagDep,
dag_run_id: str,
user: GetUserDep,
-) -> BulkResponse:
+ dry_run: bool = Query(
+ False, description="If True, return affected task instances without
making changes"
+ ),
+) -> BulkResponse | TaskInstanceCollectionResponse:
Review Comment:
We can't do this because now the client of the API doesn't know what type of
structure he's getting, and it will force a lot of `if / else` check code on
the client side. (the API here).
##########
airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx:
##########
@@ -0,0 +1,223 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Button, Flex, Heading, VStack } from "@chakra-ui/react";
+import { useState } from "react";
+import { useTranslation } from "react-i18next";
+import { useParams } from "react-router-dom";
+
+import { useTaskInstanceServiceGetTaskInstances } from "openapi/queries";
+import type {
+ BulkBody_BulkTaskInstanceBody_,
+ BulkUpdateAction_BulkTaskInstanceBody_,
+ BulkTaskInstanceBody,
+ LightGridTaskInstanceSummary,
+ TaskInstanceState,
+} from "openapi/requests/types.gen";
+import { ActionAccordion } from "src/components/ActionAccordion";
+import { StateBadge } from "src/components/StateBadge";
+import Time from "src/components/Time";
+import { Dialog } from "src/components/ui";
+import SegmentedControl from "src/components/ui/SegmentedControl";
+import { useBulkUpdateTaskInstances } from
"src/queries/useBulkUpdateTaskInstances";
+import { useBulkUpdateTaskInstancesDryRun } from
"src/queries/useBulkUpdateTaskInstancesDryRun";
+
+type Props = {
+ readonly groupTaskInstance: LightGridTaskInstanceSummary;
+ readonly onClose: () => void;
+ readonly open: boolean;
+ readonly state: TaskInstanceState;
+};
+
+const MarkGroupTaskInstanceAsDialog = ({ groupTaskInstance, onClose, open,
state }: Props) => {
+ const { t: translate } = useTranslation();
+ const { dagId = "", runId = "" } = useParams();
+ const groupId = groupTaskInstance.task_id;
+
+ const [selectedOptions, setSelectedOptions] = useState<Array<string>>([]);
+
+ const past = selectedOptions.includes("past");
+ const future = selectedOptions.includes("future");
+ const upstream = selectedOptions.includes("upstream");
+ const downstream = selectedOptions.includes("downstream");
+
+ // eslint-disable-next-line unicorn/no-null -- DAGRunResponse["note"] type
requires null, not undefined
+ const [note, setNote] = useState<string | null>(null);
+
+ const { data: groupTaskInstances } = useTaskInstanceServiceGetTaskInstances(
+ {
+ dagId,
+ dagRunId: runId,
+ taskGroupId: groupId,
+ },
+ undefined,
+ {
+ enabled: open,
+ },
+ );
Review Comment:
For instance by doing this, you only retrieve the first page, the 50 first
TI of the group, not all the TIs, so you could be missing some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
