cuerty opened a new issue, #60339:
URL: https://github.com/apache/airflow/issues/60339

   ### Official Helm Chart version
   
   1.18.0 (latest released)
   
   ### Apache Airflow version
   
   3.0.2
   
   ### Kubernetes Version
   
   v1.32.10
   
   ### Helm Chart configuration
   
   ```yaml
   revisionHistoryLimit: 0
   ```
   
   ### Docker Image customizations
   
   _No response_
   
   ### What happened
   
   Setting `revisionHistoryLimit: 0` in `values.yaml` is silently ignored. The 
rendered manifests do not include the `revisionHistoryLimit` field, causing 
Kubernetes to use its default value (10) instead of keeping zero old 
ReplicaSets.
   
   
   ### What you think should happen instead
   
   Setting `revisionHistoryLimit: 0` should render `revisionHistoryLimit: 0` in 
the deployment manifests, allowing users to disable ReplicaSet history 
retention.
   
   
   ### How to reproduce
   
   1. Set in values.yaml:
   ```yaml
   revisionHistoryLimit: 0
   ```
   
   2. Render the templates:
   ```bash
   helm template airflow apache-airflow/airflow --set revisionHistoryLimit=0 | 
grep -A2 revisionHistoryLimit
   ```
   
   ### Anything else
   
   The templates use a truthy check:
   ```yaml
   {{- if .Values.revisionHistoryLimit }}
   revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   {{- end }}
   ```
   
   In Go templates, `0` evaluates to `false`, so the block is skipped.
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to