choo121600 commented on code in PR #60346:
URL: https://github.com/apache/airflow/pull/60346#discussion_r2678502759
##########
airflow-core/src/airflow/ui/src/components/DataTable/ToggleTableDisplay.tsx:
##########
@@ -34,7 +34,7 @@ export const ToggleTableDisplay = ({ display, setDisplay }:
Props) => {
<ButtonGroup attached colorPalette="brand" pb={2} size="sm"
variant="outline">
<IconButton
aria-label={translate("toggleCardView")}
- bg={display === "card" ? "colorPalette.muted" : undefined}
+ bg={display === "card" ? "colorPalette.solid" : undefined}
Review Comment:
Is the explicit bg prop necessary here?
Since variant="solid" already applies the background color,
`bg={display === "card" ? "colorPalette.solid" : undefined}`
seems a bit redundant to me.
would it be okay to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
