SameerMesiah97 commented on PR #60352: URL: https://github.com/apache/airflow/pull/60352#issuecomment-3732762249
This looks good at first glance. But as the filter based on map index is a new addition (and likely not to be covered by existing tests), I think it would be worth adding a small test to lock in the expected behavior and guard against future regressions. In particular, it would be a good idea to cover: 1. A mapped task within a task group that produces multiple task instances (i.e. multiple map indices for the same task ID). 2. The default behavior when `map_index` is not provided, ensuring all relevant task instances are returned (including unmapped tasks). For (1), you could test both code paths by passing and omitting `task_group_id`. If feasible (and if doesn't make the test too bulky), you could cover all scenarios in a single parametrized test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
