yuseok89 opened a new pull request, #60392: URL: https://github.com/apache/airflow/pull/60392
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> closes: #60370 Fixes an issue where sensitive fields in connection `extra_fields` were incorrectly marked as "required" in the UI after redaction. The `redact()` function was masking the entire `param_dump` structure, including `schema.type`, which the frontend uses to determine if a field is optional. ## Problem When sensitive fields (e.g., `proxy`, `access_token`, `password`) in connection `extra_fields` were redacted, the `schema.type` field was also masked. The frontend's `isRequired()` logic relies on `schema.type` to determine optionality: - If `schema.type` includes `"null"` (e.g., `["string", "null"]`), the field is optional - If `schema.type` is a single type (e.g., `"string"`), the field is required When `schema.type` was masked to `"***"`, the frontend could not determine that the field was optional, causing it to be incorrectly marked as required. ### Before <img width="764" height="621" alt="image" src="https://github.com/user-attachments/assets/5970d67a-31b1-4023-bb5f-00b372a90f40"; /> ### After <img width="768" height="602" alt="image" src="https://github.com/user-attachments/assets/e917cbc0-dbc8-4694-a627-6d9953db0ff6"; /> ## Solution Modified the `redact_extra_fields` validator in `ConnectionHookMetaData` to: 1. Store the original `schema.type` values before applying redaction 2. Apply the standard `redact()` function to mask sensitive values 3. Restore the original `schema.type` for param spec structures to preserve optionality This ensures that sensitive fields are properly masked (value, title, description) while maintaining their optional status in the UI. ## Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
