uranusjr commented on code in PR #60394:
URL: https://github.com/apache/airflow/pull/60394#discussion_r2681036663
##########
providers/google/src/airflow/providers/google/cloud/triggers/cloud_run.py:
##########
@@ -71,6 +74,7 @@ def __init__(
impersonation_chain: str | Sequence[str] | None = None,
polling_period_seconds: float = 10,
timeout: float | None = None,
+ transport: str | None = None,
Review Comment:
If this defaults to "grpc", why not just do `transport: str = "grpc"`?
Also it might be a good idea to use Literal here? I’m not sure if the
transports supported by these operators a static or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
