Miretpl commented on code in PR #58547:
URL: https://github.com/apache/airflow/pull/58547#discussion_r2683383930
##########
helm-tests/tests/helm_tests/airflow_core/test_worker.py:
##########
@@ -1519,7 +1519,7 @@ def test_worker_template_storage_class_name(self,
workers_values):
({"celery": {"replicas": 2}}, 2),
({"celery": {"replicas": None}}, 1),
({"replicas": 2, "celery": {"replicas": 3}}, 3),
- ({"replicas": 2, "celery": {"replicas": None}}, 2),
+ ({"replicas": 2, "celery": {"replicas": 2}}, 2),
Review Comment:
With moving from `workers.replicas` to `workers.celery.replicas`, we want to
make sure that when users unset the `workers.celery.replicas` field, the
behaviour will be as in previous releases (because we changed how chart behaves
in replicas handling). Why was this change made?
I see now locally that this was changed as the default behaviour was
changed. `workers.replicas`, if `workers.celery.replicas` is unset, does't
change the value of replicas. I think it should be fixed in the template logic,
not in the test case itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
