jscheffl commented on PR #60319: URL: https://github.com/apache/airflow/pull/60319#issuecomment-3740789939
> The only non-blocking suggestion I have is to mention these test additions/adjustments in the PR description, as that context helps reduce review friction. And, for future reference, I would advise you to squash commit when you rebase with one descriptive commit if the change is relatively minor. No need to do this now as there might be requests for changes. No, in my view squashing is not needed. During merge all commits are squashed so if more commits are coming it is fine to collect and rebase. In my even makes it simpler in a re-review what has been changed after last review cycle. If always all commits are squashed I always need to make a full review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
