cruseakshay opened a new pull request, #60440:
URL: https://github.com/apache/airflow/pull/60440
This PR adds support for cancelling EMR Serverless jobs when an Airflow task
is killed while in deferrable mode.
**Problem:**
When using `EmrServerlessStartJobOperator` with `deferrable=True`, if a user
cancels the task in Airflow, the EMR Serverless job continues running in AWS.
This leads to orphaned jobs consuming resources
**Solution:**
Implements the "cancel_on_kill" (similar to `DataprocSubmitJobTrigger`) for
EMR Serverless:
1. Added `cancel_on_kill` parameter to `EmrServerlessStartJobOperator`
(default: `True`)
2. Added `cancel_on_kill` parameter to `EmrServerlessStartJobTrigger`
3. Implemented `safe_to_cancel()` method in the trigger to distinguish
between:
- User-initiated cancellation (task state changed from DEFERRED) → Cancel
the EMR job
- Triggerer shutdown/restart → Keep the EMR job running
4. Override `run()` method to catch `asyncio.CancelledError` and cancel the
EMR job when safe
**Changes:**
- `providers/amazon/aws/operators/emr.py`: Added `cancel_on_kill` parameter
- `providers/amazon/aws/triggers/emr.py`: Added cancellation logic with
`safe_to_cancel()`
- `tests/unit/amazon/aws/triggers/test_emr.py`: Added unit tests for
cancellation scenarios
**Testing:**
- ✅ Unit tests added and passing
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes - Claude (Cursor IDE)
Generated-by: Claude (Cursor IDE) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
