pierrejeambrun commented on code in PR #60412:
URL: https://github.com/apache/airflow/pull/60412#discussion_r2685788198
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py:
##########
@@ -170,7 +170,7 @@ def get_log(
@task_instances_log_router.get(
"/{task_id}/externalLogUrl/{try_number}",
responses=create_openapi_http_exception_doc([status.HTTP_400_BAD_REQUEST,
status.HTTP_404_NOT_FOUND]),
- dependencies=[Depends(requires_access_dag("GET",
DagAccessEntity.TASK_INSTANCE))],
+ dependencies=[Depends(requires_access_dag("GET",
DagAccessEntity.TASK_LOGS))],
Review Comment:
Since `TASK_LOGS` and `TASK_INSTANCE` are distinct DagAccessEntity I think
it's fine.
We also only have `TASK_LOGS` above for `get_log`. Indeed the endpoint needs
to fetch the particular TI to construct the log, but as long as we return the
log only I think we are good.
Otherwise I feel this could confuse users, having access to read logs of
Task Instance 1 and still not be able to read logs of Task Instance 1 would be
weird. (because TASK_INSTANCE on Task Instance 1 permission is missing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
