robinedwards commented on a change in pull request #6684: [AIRFLOW-6095] Filter
dags returned by task_stats
URL: https://github.com/apache/airflow/pull/6684#discussion_r353507322
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -403,7 +405,7 @@ <h2>DAGs</h2>
container: "body",
});
});
- d3.json("{{ url_for('Airflow.task_stats') }}", function(error, json) {
+ d3.json("{{ url_for('Airflow.task_stats') }}?dag_ids=" +
all_dags_ids.join(','), function(error, json) {
Review comment:
Passing get parameters like you suggested above wasn't supported by d3.json
so instead I've encoded each dag_id. I thought about passing the`dag_id=`
multiple times but it does result in a rather long GET header (which I believe
is often capped at 8kb?). This could potentially overflow for users with 100
dags per page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
