[
https://issues.apache.org/jira/browse/AIRFLOW-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987406#comment-16987406
]
ASF GitHub Bot commented on AIRFLOW-4922:
-----------------------------------------
ITriangle commented on pull request #6722: [AIRFLOW-4922]Fix task get log by
Web UI
URL: https://github.com/apache/airflow/pull/6722
[AIRFLOW-4922]Fix task get log by Web UI
When getting logs, querying task_instance does not get the exact hostname.
Need to cooperate with the log table and try number
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4922
In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
When getting logs, querying task_instance does not get the exact hostname.
Need to cooperate with the log table and try number
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
test my local Airflow Cluster
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> If a task crashes, host name is not committed to the database so logs aren't
> able to be seen in the UI
> ------------------------------------------------------------------------------------------------------
>
> Key: AIRFLOW-4922
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4922
> Project: Apache Airflow
> Issue Type: Bug
> Components: logging
> Affects Versions: 1.10.3
> Reporter: Andrew Harmon
> Priority: Major
>
> Sometimes when a task fails, the log show the following
> {code}
> *** Log file does not exist:
> /usr/local/airflow/logs/my_dag/my_task/2019-07-07T09:00:00+00:00/1.log***
> Fetching from:
> http://:8793/log/my_dag/my_task/2019-07-07T09:00:00+00:00/1.log***
> Failed to fetch log file from worker. Invalid URL
> 'http://:8793/log/my_dag/my_task/2019-07-07T09:00:00+00:00/1.log': No host
> supplied
> {code}
> I believe this is due to the fact that the row is not committed to the
> database until after the task finishes.
> https://github.com/apache/airflow/blob/a1f9d9a03faecbb4ab52def2735e374b2e88b2b9/airflow/models/taskinstance.py#L857
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
