pierrejeambrun commented on code in PR #59643:
URL: https://github.com/apache/airflow/pull/59643#discussion_r2686746701
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -234,6 +243,23 @@ def test_connection(
try:
data = test_body.model_dump(by_alias=True)
data["conn_id"] = transient_conn_id
+
+ if use_existing_credentials:
+ try:
+ existing_conn =
Connection.get_connection_from_secrets(test_body.connection_id)
Review Comment:
I would recommend this, but I realize that `get_connection_from_secrets`
already returns an orm instance, so it will not be a big effort to support
private backend connection too. We can keep the `get_connection_from_secrets`
to allow testing all connections.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -234,6 +243,23 @@ def test_connection(
try:
data = test_body.model_dump(by_alias=True)
data["conn_id"] = transient_conn_id
+
+ if use_existing_credentials:
+ try:
+ existing_conn =
Connection.get_connection_from_secrets(test_body.connection_id)
Review Comment:
I would recommend this, but I realize that `get_connection_from_secrets`
already returns an orm instance, so it will not be a big effort to support
private backend connection too. We can keep the `get_connection_from_secrets`
to allow testing all connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
